Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the additional numpy 1.16 test #778

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

joshmoore
Copy link
Member

@joshmoore joshmoore commented Jun 17, 2021

Builds that are pinned to the 1.16.x numpy series are starting to fail. Dropping those in favor of 1.17.x numpy to keep as much backwards compatibility as possible.

see:

@joshmoore
Copy link
Member Author

All tests are green except for the one 1.16.x build which was removed here (and therefore is blocked)

Merging to try to get other PRs green. If there are any objections to dropping this particular test, we can resurrect without impacting end-users.

@joshmoore joshmoore merged commit dd0e779 into zarr-developers:master Jun 17, 2021
@joshmoore joshmoore deleted the drop-numpy-1.16 branch June 17, 2021 07:31
@jakirkham
Copy link
Member

NumPy 1.20 is the current version (and has already seen a few patch releases). Plus NumPy 1.21 already had RC 2 come out over a week ago (so is probably coming out soon). Given the pace of NumPy releases, where NumPy is at version-wise, and the general ease of installing NumPy these days, bumping to 1.17 seems pretty reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants